Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12497#issuecomment-212361373
Since this is something that would be good to do globally, if at all, and
there are automated tools to find this type of problem, I'd run an IDE over
this to find and fix them in one go. For example, I pushed a button in IDEA and
found more unused imports in:
ExternalShuffleBlockHandlerSuite.java
SparkSubmitOptionParserSuite.java
TransportResponseHandlerSuite.java
UnsafeRow.java
Although it also easily flags unused imports in Scala in the editor, I
couldn't find an inspection for it. It does let you automatically optimize
imports in Scala, though by default it will reorder them and other things,
which can be disabled. It still seems like a hard way to just discover unused
imports without changing a lot of stuff. For now if we can get as many fixed in
one go as is reasonably possible, maybe that's sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]