Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12402#discussion_r60421055
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala ---
@@ -105,6 +108,15 @@ class GaussianMixtureModel private[ml] (
def gaussians: Array[MultivariateGaussian] = parentModel.gaussians
@Since("2.0.0")
--- End diff --
@jkbradley @wangmiao1981 I vote ```GaussianMixtureModel.gaussians``` should
return type of ```DataFrame``` for both Scala and Python, we need the same
return type for different languages.
I refer that ```LDAModel.describeTopics``` and
```Word2VecModel.findSynonyms``` both return ```DataFrame``` in ML, but they
use wrapper in MLlib such as
[```describeTopics```](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/api/python/LDAModelWrapper.scala#L34).
I think return ```DataFrame``` for this kind of return value is good idea. I'm
open to hear your thoughts. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
