Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12530#issuecomment-212492341
From my understanding `tol` is fairly generic. I tend to agree that `tol`
should be > 0, but since convergence tolerance can be specified in many number
of ways (with arbitrary units), I'm not sure it should be <= 1. I don't feel
too strongly about it though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
