Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212574884
Minor nit: Maybe s/omissive/missing/ for clarity while reading the title?
If all of our Params use type converter, maybe we should remove the default
param of none and expected type for 2.0 - the docs mention keeping expected
type until 2.1 but that seems maybe a bit longer than necessary if we've
completely switched all of our internal types over and while the Params API is
technically public I think requiring an explicit type converter specified would
be a reasonable change for the 2.0 time frame. Just a thought, what do @sethah
& @jkbradley think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
