Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/12420#issuecomment-212586566
  
    @pravingadakh Thanks!  This is what I had in mind.  In your tests, could 
you please add Java unit tests too to make sure these are Java-friendly?
    
    Also, please check the type and throw exceptions when the type does not 
match.  I'd recommend throwing IllegalArgumentException and specifying the 
expected and actual types.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to