Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12464#discussion_r60508016
--- Diff: python/pyspark/ml/tests.py ---
@@ -534,6 +534,8 @@ def test_save_load(self):
cvModel.save(cvModelPath)
loadedModel = CrossValidatorModel.load(cvModelPath)
self.assertEqual(loadedModel.bestModel.uid, cvModel.bestModel.uid)
+ for index in range(len(loadedModel.avgMetrics)):
--- End diff --
Minor possible suggestion, there are some other places in the doctests
where we use numpys assert_almost_equal, it seems like that might simplify
things here a bit if you wanted to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
