Github user nirandaperera commented on the pull request:

    https://github.com/apache/spark/pull/12506#issuecomment-212841502
  
    @mridulm You are correct. But if we check the register application method, 
    
    `  private def registerApplication(app: ApplicationInfo): Unit = {
        val appAddress = app.driver.address
        if (addressToApp.contains(appAddress)) {
          logInfo("Attempted to re-register application at same address: " + 
appAddress)
          return
        }
    
        applicationMetricsSystem.registerSource(app.appSource)
        apps += app
        idToApp(app.id) = app
        endpointToApp(app.driver) = app
        addressToApp(appAddress) = app
        waitingApps += app
      }`
    
    there are similar array buffers which are getting updated without being 
synchronized. That is why I omitted making the waitingAppsWhileRecovering 
synchronized. 
    am I doing anything wrong there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to