Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12500#discussion_r60607695
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
@@ -79,16 +79,20 @@ private[ml] object TreeTests extends SparkFunSuite {
* This must be non-empty.
* @param numClasses Number of classes label can take. If 0, mark as
continuous.
* @param labelColName Name of the label column on which to set the
metadata.
+ * @param featuresColName Name of the features column
* @return DataFrame with metadata
*/
- def setMetadata(data: DataFrame, numClasses: Int, labelColName: String):
DataFrame = {
+ def setMetadata(data: DataFrame,
--- End diff --
Follow Spark style here:
```scala
def setMetadata(
data: DataFrame,
numClasses: Int,
labelColName: String,
featuresColName: String): DataFrame = {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
