Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12584#discussion_r60655389
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTable.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command
+
+import scala.util.control.NonFatal
+
+import org.apache.hadoop.fs.{FileSystem, Path}
+
+import org.apache.spark.sql.{Row, SQLContext}
+import org.apache.spark.sql.catalyst.analysis.EliminateSubqueryAliases
+import org.apache.spark.sql.catalyst.catalog.{CatalogRelation,
CatalogTable}
+
+
+/**
+ * Analyzes the given table in the current database to generate
statistics, which will be
+ * used in query optimizations.
+ *
+ * Right now, it only supports Hive tables and it only updates the size of
a Hive table
+ * in the Hive metastore.
+ */
+case class AnalyzeTable(tableName: String) extends RunnableCommand {
+
+ override def run(sqlContext: SQLContext): Seq[Row] = {
+ val sessionState = sqlContext.sessionState
+ val tableIdent = sessionState.sqlParser.parseTableIdentifier(tableName)
+ val relation =
EliminateSubqueryAliases(sessionState.catalog.lookupRelation(tableIdent))
+
+ relation match {
+ case relation: CatalogRelation =>
+ val catalogTable: CatalogTable = relation.catalogTable
+ // This method is mainly based on
+ //
org.apache.hadoop.hive.ql.stats.StatsUtils.getFileSizeForTable(HiveConf, Table)
+ // in Hive 0.13 (except that we do not use fs.getContentSummary).
+ // TODO: Generalize statistics collection.
+ // TODO: Why fs.getContentSummary returns wrong size on Jenkins?
+ // Can we use fs.getContentSummary in future?
+ // Seems fs.getContentSummary returns wrong table size on Jenkins.
So we use
+ // countFileSize to count the table size.
+ val stagingDir =
sessionState.conf.getConfString("hive.exec.stagingdir", ".hive-staging")
+
+ def calculateTableSize(fs: FileSystem, path: Path): Long = {
+ val fileStatus = fs.getFileStatus(path)
+ val size = if (fileStatus.isDirectory) {
+ fs.listStatus(path)
+ .map { status =>
+ if (!status.getPath.getName.startsWith(stagingDir)) {
+ calculateTableSize(fs, status.getPath)
+ } else {
+ 0L
+ }
+ }.sum
+ } else {
+ fileStatus.getLen
+ }
+
+ size
+ }
+
+ val tableParameters = catalogTable.properties
+ val oldTotalSize =
tableParameters.get("totalSize").map(_.toLong).getOrElse(0L)
+ val newTotalSize =
+ catalogTable.storage.locationUri.map { p =>
+ val path = new Path(p)
+ try {
+ val fs =
path.getFileSystem(sqlContext.sparkContext.hadoopConfiguration)
+ calculateTableSize(fs, path)
+ } catch {
+ case NonFatal(e) =>
+ logWarning(
+ s"Failed to get the size of table
${catalogTable.identifier.table} in the " +
+ s"database ${catalogTable.identifier.database} because
of ${e.toString}", e)
+ 0L
+ }
+ }.getOrElse(0L)
+
+ // Update the Hive metastore if the total size of the table is
different than the size
+ // recorded in the Hive metastore.
+ // This logic is based on
org.apache.hadoop.hive.ql.exec.StatsTask.aggregateStats().
+ if (newTotalSize > 0 && newTotalSize != oldTotalSize) {
+ sessionState.catalog.alterTable(
+ catalogTable.copy(
+ properties = relation.catalogTable.properties +
+ (AnalyzeTable.TOTAL_SIZE_FIELD -> newTotalSize.toString)))
--- End diff --
this was using some hive constant -- changed to use an internal constant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
