Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/12570#issuecomment-213140513
From what I can tell you reimplemented `LogPage` for yarn specifically.
Wouldn't it make more sense to extend and surface `LogPage` for your use case?
I've read through your code a bit and it looks like you have some good
improvements over certain parts of `LogPage` but I think creating a completely
separate log viewer for yarn is unnecessary and redundant. (Also note my other
observations in the Jira.)
@srowen: you were commenting on the Jira, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
