Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12577#discussion_r60697050
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala 
---
    @@ -69,7 +69,27 @@ final class RegressionEvaluator @Since("1.4.0") 
(@Since("1.4.0") override val ui
       @Since("1.4.0")
       def setLabelCol(value: String): this.type = set(labelCol, value)
     
    -  setDefault(metricName -> "rmse")
    +  /**
    +   * Param for whether to drop rows where 'predictionCol' is NaN. NOTE - 
only set this to
    +   * true if you are certain that NaN predictions should be ignored!
    +   * (default: false)
    +   *
    +   * @group expertParam
    +   */
    +  @Since("2.0.0")
    +  val dropNaN: BooleanParam = new BooleanParam(this, "dropNaN",
    --- End diff --
    
    Let me see how nulls are handled given nullable input columns, and perhaps 
the possible strategies can be adjusted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to