Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12599#discussion_r60704321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -83,6 +83,16 @@ case class SerializeFromObject(
child: LogicalPlan) extends UnaryNode with ObjectConsumer {
override def output: Seq[Attribute] = serializer.map(_.toAttribute)
+
+ // We can't estimate the size of ObjectType. We implement statistics
here to avoid
+ // directly estimate any child plan which produces domain objects as
output.
+ override def statistics: Statistics = {
+ if (child.output.head.dataType.isInstanceOf[ObjectType]) {
+ Statistics(sizeInBytes = Long.MaxValue)
--- End diff --
or should we go deeper to find the first child that doesn't output objects
and take its statistic? Returning Long.max means we can't broadcast join a plan
having object operators, which is bad for `Dataset`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
