GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/12624
[SPARK-14852][ML] refactored GLM summary into training, non-training
summaries
## What changes were proposed in this pull request?
This splits GeneralizedLinearRegressionSummary into 2 summary types:
* GeneralizedLinearRegressionSummary, which does not store info from
fitting (diagInvAtWA)
* GeneralizedLinearRegressionTrainingSummary, which is a subclass of
GeneralizedLinearRegressionSummary and stores info from fitting
This also add a method evaluate() which can produce a
GeneralizedLinearRegressionSummary on a new dataset.
The summary no longer provides the model itself as a public val.
Also:
* Fixes bug where GeneralizedLinearRegressionTrainingSummary was created
with model, not summaryModel.
* Adds hasSummary method.
* Renames findSummaryModelAndPredictionCol -> getSummaryModel and
simplifies that method.
* In summary, extract values from model immediately in case user later
changes those (e.g., predictionCol).
* Pardon the style fixes; that is IntelliJ being obnoxious.
## How was this patch tested?
Existing unit tests + updated test for evaluate and hasSummary
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark model-summary-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12624
----
commit b8e20d73971b6547f87757dba17c4b4190f86db1
Author: Joseph K. Bradley <[email protected]>
Date: 2016-04-22T20:19:07Z
refactored GLM summary into training, non-training summaries
commit 98fa4ea0e5abcc230d57db51eac56ad21aeee1e8
Author: Joseph K. Bradley <[email protected]>
Date: 2016-04-22T22:24:38Z
fixed IntelliJ style mistakes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
