Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12625#discussion_r60812435
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -356,14 +356,14 @@ private[clustering] trait LDAParams extends Params
with HasFeaturesCol with HasM
* Model fitted by [[LDA]].
*
* @param vocabSize Vocabulary size (number of terms or terms in the
vocabulary)
- * @param sqlContext Used to construct local DataFrames for returning
query results
+ * @param sparkSession Used to construct local DataFrames for returning
query results
*/
@Since("1.6.0")
@Experimental
sealed abstract class LDAModel private[ml] (
@Since("1.6.0") override val uid: String,
@Since("1.6.0") val vocabSize: Int,
- @Since("1.6.0") @transient protected val sqlContext: SQLContext)
+ @Since("1.6.0") @transient protected[ml] val sparkSession:
SparkSession)
--- End diff --
this will break MIMA but it's probably OK because we don't expect people to
extend `LDAModel`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
