GitHub user arashn opened a pull request:
https://github.com/apache/spark/pull/12628
[SPARK-14757][SQL] Corrected doGenCode() in EqualNullSafe predicate
## What changes were proposed in this pull request?
In the doGenCode() function for the EqualNullSafe predicate, in determining
whether the two operands are equal, check that the right operand is not null,
in addition to checking the left operand. This is because if only one of the
operands is null, then the two operands are guaranteed not to be equal.
Therefore, in order to have a valid comparison using `==`, both operands have
to be non-null.
## How was this patch tested?
This patch was tested using the example given in the JIRA for this issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arashn/spark equalnullsafe-codegen-correction
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12628
----
commit c3410291f3e0efbea075b889b6c466ad19589c6f
Author: Arash Nabili <[email protected]>
Date: 2016-04-22T23:54:02Z
Corrected doGenCode() in EqualNullSafe predicate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
