GitHub user lw-lin opened a pull request:

    https://github.com/apache/spark/pull/12638

    [SPARK-14874][SQL][Streaming] Cleanup the useless Batch class

    ## What changes were proposed in this pull request?
    
    The `Batch` class, which had been used to indicate progress in a stream, 
was abandoned by [[SPARK-13985][SQL] Deterministic batches with 
ids](https://github.com/apache/spark/commit/caea15214571d9b12dcf1553e5c1cc8b83a8ba5b)
 and then became useless.
    
    This patch:
    - removes the `Batch` class
    - renames `getBatch(...)` to `getData(...)` for `Source`: 
     - before 
[SPARK-13985](https://github.com/apache/spark/commit/caea15214571d9b12dcf1553e5c1cc8b83a8ba5b),
 it was: get**_NextBatch_**(start: Option[Offset]): **_Option[Batch]_**
     - after  
[SPARK-13985](https://github.com/apache/spark/commit/caea15214571d9b12dcf1553e5c1cc8b83a8ba5b),
 it became: get**_Batch_**(start: Option[Offset], end: Offset): **_DataFrame_**
     - proposed in this patch: get**_Data_**(start: Option[Offset], end: 
Offset): DataFrame
    - renames `addBatch(...)` to `addData(...)` for `Sink`:
     - before 
[SPARK-13985](https://github.com/apache/spark/commit/caea15214571d9b12dcf1553e5c1cc8b83a8ba5b),
 it was: addBatch(**_batch: Batch_**)
     - after  
[SPARK-13985](https://github.com/apache/spark/commit/caea15214571d9b12dcf1553e5c1cc8b83a8ba5b),
 it became: addBatch(batchId: Long, **_data: DataFrame_**)
     - proposed in this patch: add**_Data_**(batchId: Long, data: DataFrame)
    
    ## How was this patch tested?
    
    The changes should be covered by existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lw-lin/spark remove-batch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12638
    
----
commit c79cba9059b7ac2d6398c81b57ceece50b6b7526
Author: Liwei Lin <lwl...@gmail.com>
Date:   2016-04-23T10:15:51Z

    remove the useless Batch class

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to