Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12632#issuecomment-213906023
Hi, @rxin . Thank you for review. FYI, here is the result of
`dev/lint-java` of current master branch.
```bash
spark:master$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks failed at following occurrences:
[ERROR]
src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java:[259]
(sizes) LineLength: Line is longer than 100 characters (found 103).
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[25,8]
(imports) UnusedImports: Unused import - org.apache.spark.util.Utils.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[72,17]
(modifier) ModifierOrder: 'abstract' modifier out of order with the JLS
suggestions.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[85,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[86,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[88,12]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[94,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[95,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[97,12]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[103,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[104,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[106,12]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[112,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[113,22]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java:[115,12]
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/RadixSort.java:[19]
(regexp) RegexpSingleline: No trailing whitespace allowed.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/RadixSort.java:[230]
(regexp) RegexpSingleline: No trailing whitespace allowed.
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:[215]
(sizes) LineLength: Line is longer than 100 characters (found 103).
[ERROR]
src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[41,8]
(imports) UnusedImports: Unused import - org.apache.hadoop.fs.FileSystem.
[ERROR]
src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java:[84,26]
(misc) ArrayTypeStyle: Array brackets at illegal position.
[ERROR]
src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java:[88,29]
(misc) ArrayTypeStyle: Array brackets at illegal position.
[ERROR]
src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java:[92,29]
(misc) ArrayTypeStyle: Array brackets at illegal position.
[ERROR]
src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java:[84,26]
(misc) ArrayTypeStyle: Array brackets at illegal position.
[ERROR]
src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java:[88,29]
(misc) ArrayTypeStyle: Array brackets at illegal position.
[ERROR]
src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java:[92,29]
(misc) ArrayTypeStyle: Array brackets at illegal position.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
