Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12528#discussion_r60841893
--- Diff: bin/pyspark ---
@@ -33,8 +33,9 @@ export _SPARK_CMD_USAGE="Usage: ./bin/pyspark [options]"
# PYSPARK_DRIVER_PYTHON_OPTS to pass options when starting the Python
driver
# (e.g. PYSPARK_DRIVER_PYTHON_OPTS='notebook'). This supports full
customization of the IPython
# and executor Python executables.
-#
-# For backwards-compatibility, we retain the old IPYTHON and IPYTHON_OPTS
variables.
+#
--- End diff --
The whole block of docs above this could be removed.
while you're at it, one last change would be helpful: mention in
`programming-guide.md` that `jupyter` works too, where it shows the `ipython`
example. Just a sentence noting that is OK.
LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
