Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12612#issuecomment-214017619
cc @rxin , several questions need to be discussed:
1. should we provide the metadata while creating accumulators instead of
registration? e.g., `id` can be fixed like `private[spark] val id =
AccumulatorContext.newId()`, `name` and `countFailedValues` can be ctor
parameters.
2. should we still have `Accumulable` and `Accumulator`? `Accumulator` is a
special `Accumulable` that input and output types are same.
3. Do we really need the `merge` method? I don't see any places use it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
