Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12651#discussion_r60860719
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala ---
    @@ -103,6 +103,19 @@ private[sql] trait SQLTestData { self =>
         df
       }
     
    +  protected lazy val decimalDataWithNulls: DataFrame = {
    --- End diff --
    
    let's not define this here - just put it into the test case.
    
    We wanted to get rid of SQLTestData actually, because it makes test cases 
much harder to read, but never had a chance to do it fully.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to