Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r60950643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1051,6 +1053,22 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
}
/**
+ * Create a name LTRIM for TRIM(Leading), RTRIM for TRIM(Trailing), TRIM
for TRIM(BOTH)
+ */
+ private def getTrimFuncName(ctx: FunctionCallContext, optType: Int):
String = {
+ if (ctx.qualifiedName.getText.toLowerCase != "trim") {
+ throw new ParseException(s"The specified function
${ctx.qualifiedName.getText} " +
--- End diff --
Hi, @kevinyu98 .
There are two spaces after `${ctx.qualifiedName.getText}`. We had better to
reduce that into one space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
