Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12574#discussion_r60959688
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala 
---
    @@ -200,8 +240,42 @@ class ALSModel private[ml] (
       @Since("1.3.0")
       def setPredictionCol(value: String): this.type = set(predictionCol, 
value)
     
    +  /** @group setParam */
       @Since("2.0.0")
    +  def setLabelCol(value: String): this.type = set(labelCol, value)
    +
    +  /** @group setParam */
    +  @Since("2.0.0")
    +  def setK(value: Int): this.type = set(k, value)
    +
    +  /** @group setParam */
    +  @Since("2.0.0")
    +  def setRecommendFor(value: String): this.type = set(recommendFor, value)
    --- End diff --
    
    Would it make sense to set `recommendFor` and `k` together?  like this
    ```
    def setRecommendFor(forval: String, kval: Int)
    ```
    That way you would be guaranteed they are both set if using recommendFor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to