Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12659#discussion_r60971154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -622,40 +620,44 @@ class SessionCatalog(
* based on the function class and put the builder into the
FunctionRegistry.
* The name of this function in the FunctionRegistry will be
`databaseName.functionName`.
*/
- def lookupFunction(name: String, children: Seq[Expression]): Expression
= {
- // TODO: Right now, the name can be qualified or not qualified.
- // It will be better to get a FunctionIdentifier.
- // TODO: Right now, we assume that name is not qualified!
- val qualifiedName = FunctionIdentifier(name,
Some(currentDb)).unquotedString
- if (functionRegistry.functionExists(name)) {
+ def lookupFunction(name: FunctionIdentifier, children: Seq[Expression]):
Expression = {
--- End diff --
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
