Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11871#discussion_r60991630
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
    @@ -98,7 +46,7 @@ class StopWordsRemover(override val uid: String)
     
       /**
        * the stop words set to be filtered out
    -   * Default: [[StopWords.English]]
    +   * Default: [[Array.empty]]
    --- End diff --
    
    This could be a little clearer with the scaladoc, I think we should mention 
that Array.empty actually implies loading the english stop words. (Or we could 
just have the default be the loaded version of the english stop words as is 
done in the PySpark code).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to