Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12593#discussion_r60996174
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala ---
    @@ -17,17 +17,19 @@
     
     package org.apache.spark.ml.clustering
     
    +import breeze.linalg.{DenseVector => BDV}
     import org.apache.hadoop.fs.Path
     
     import org.apache.spark.SparkContext
     import org.apache.spark.annotation.{Experimental, Since}
     import org.apache.spark.ml.{Estimator, Model}
    +import org.apache.spark.ml.impl.Utils.EPSILON
     import org.apache.spark.ml.param.{IntParam, ParamMap, Params}
     import org.apache.spark.ml.param.shared._
    +import org.apache.spark.ml.stat.distribution.MultivariateGaussian
     import org.apache.spark.ml.util._
    -import org.apache.spark.mllib.clustering.{GaussianMixture => MLlibGM, 
GaussianMixtureModel => MLlibGMModel}
    +import org.apache.spark.mllib.clustering.{GaussianMixture => MLlibGM}
     import org.apache.spark.mllib.linalg._
    --- End diff --
    
    Do we want to import both `ml` and `mllib` linalg, and use `ml` 
implementation as much as possible but return the `mllib` implementation for 
now until the `ml` `UDT` is merged? Thus, we can just do a slight modification 
once `UDT` is done. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to