Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12222#discussion_r61006959
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -424,7 +424,7 @@ private[sql] object PartitioningUtils {
path.foreach { c =>
if (needsEscaping(c)) {
builder.append('%')
- builder.append(f"${c.asInstanceOf[Int]}%02x")
+ builder.append(f"${c.asInstanceOf[Int]}%02X")
--- End diff --
@liancheng So i was comparing the output of our impl against hive. And hive
reports the escaped name in upper case, I looked at FileUtils.escapePathName()
in hive as reference before changing the code here. Please let me know what you
think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
