Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12604#discussion_r61016865
  
    --- Diff: python/pyspark/ml/tuning.py ---
    @@ -141,6 +144,71 @@ def getEvaluator(self):
             """
             return self.getOrDefault(self.evaluator)
     
    +    def _transfer_param_map_to_java_impl(self, pyParamMap, java_obj):
    +        """
    +        Transfer a Python ParamMap to a Java ParamMap which belongs to an 
Java estimator of
    +        ValidatorParams.
    +        This utility method helps CrossValidator and TrainValidationSplit 
implementing their
    +        _transfer_param_map_to_java().
    +        """
    +        estimator, epms, evaluator, seed = self._to_java_impl()
    --- End diff --
    
    This is getting the Python Params from the class, not from pyParamMap.  It 
should get them from pyParamMap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to