Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61042431
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + str(expected[i]) + ",
got " + str(features[i]))
+class ALSTest(PySparkTestCase):
+
+ def test_storage_levels(self):
--- End diff --
Yeah both tests are redundant. I guess I was erring on the side of
over-caution :) I didn't really want to put a simple test in the doc string,
since it's expertParam and probably should stay a bit "hidden".
I can remove these tests, or any other suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
