Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12696#discussion_r61043851
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -686,7 +686,14 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
val stream = new java.io.PrintStream(buffer, true, "UTF-8")
// scalastyle:off println
- stream.println("test circular test circular test circular test
circular test circular")
+ // Note: println will append '\r\n' in windows,
+ // so there will be one more byte comparing to Unix/Linux.
+ if (Utils.isWindows) {
+ stream.print("test circular test circular test circular test
circular test circular\n")
--- End diff --
Just use this form for all platforms. No need to special-case Windows
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
