Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61044982
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Logging {
if (fs.exists(partitionerFilePath)) {
val fileInputStream = fs.open(partitionerFilePath, bufferSize)
val serializer = SparkEnv.get.serializer.newInstance()
- val deserializeStream =
serializer.deserializeStream(fileInputStream)
+ // make sure that the file is closed if error occurrs during
deserialization
+ val deserializeStream =
--- End diff --
The `deserializeStream` will be closed. We only need this when the
`deserializeStream` method throws exception and we have no chance to go to the
line 258, in which the `deserializeStream` will be closed, with the inner
`fileInputStream`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
