Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12309#discussion_r61049111
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala 
---
    @@ -271,6 +271,15 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] 
extends Serializable {
         rdd.pipe(command.asScala, env.asScala)
     
       /**
    +   * Return an RDD created by piping elements to a forked external process.
    +   */
    +  def pipe(command: JList[String],
    +           env: java.util.Map[String, String],
    --- End diff --
    
    Optional: wouldn't mind importing this as JMap and using it consistently in 
this file while we're here.
    
    This can also take arguments for `printPipeContext` and `printRDDElement`. 
That's not part of your change of course but make sense to fix this omission 
while adding the all-args API method to support the new arg.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to