Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12702#discussion_r61146517
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -135,18 +135,20 @@ object HashingTF {
private[spark] val Murmur3: String = "murmur3"
- private[spark] val supportedHashAlgorithms: Array[String] =
Array(Native, Murmur3)
+ private[spark] val supportedHashAlgorithms: Array[String] =
Array(Murmur3)
--- End diff --
So its a bit weird that we're using supportedHashAlgorithms in mllib from
ml, maybe we should just move this over there to reduce the confusion? Since we
still intend to (at least temporarily) support native in MLLib but not in ml.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
