Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12673#discussion_r61150552
  
    --- Diff: python/pyspark/sql/streaming.py ---
    @@ -51,22 +51,22 @@ def isActive(self):
             return self._jcq.isActive()
     
         @since(2.0)
    -    def awaitTermination(self, timeoutMs=None):
    +    def awaitTermination(self, timeout=None):
             """Waits for the termination of `this` query, either by 
:func:`query.stop()` or by an
             exception. If the query has terminated with an exception, then the 
exception will be thrown.
    -        If `timeoutMs` is set, it returns whether the query has terminated 
or not within the
    -        `timeoutMs` milliseconds.
    +        If `timeout` is set, it returns whether the query has terminated 
or not within the
    +        `timeout` seconds.
     
             If the query has terminated, then all subsequent calls to this 
method will either return
             immediately (if the query was terminated by :func:`stop()`), or 
throw the exception
             immediately (if the query has terminated with exception).
     
    -        throws ContinuousQueryException, if `this` query has terminated 
with an exception
    +        throws :class:`ContinuousQueryException`, if `this` query has 
terminated with an exception
             """
    -        if timeoutMs is not None:
    -            if type(timeoutMs) != int or timeoutMs < 0:
    -                raise ValueError("timeoutMs must be a positive integer. 
Got %s" % timeoutMs)
    -            return self._jcq.awaitTermination(timeoutMs)
    +        if timeout is not None:
    +            if type(timeout) != int or timeout < 0:
    +                raise ValueError("timeout must be a positive integer. Got 
%s" % timeout)
    +            return self._jcq.awaitTermination(timeout)
    --- End diff --
    
    The awaitTermination() in Java expect milli-seconds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to