Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12663#issuecomment-214889338
If SPARK-7126 were implemented, would this patch still be useful? We could
just check for absence of metadata and prepend a StringIndexer. I guess my
question is this: Can we avoid some of the fuzziness and potentially confusing
situations that might be introduced by this patch, by simply implementing
SPARK-7126? If we could, then I think it's a tradeoff between complexity,
urgency, and correctness. It's hard for me to say without knowing more about
how this affects and has affected users and what specifically is driving this
change.
That said, I think 100 is a reasonable number for `maxNumClasses` and the
updates look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
