Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12689#discussion_r61177026
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala ---
    @@ -85,27 +85,4 @@ class SQLContextSuite extends SparkFunSuite with 
SharedSparkContext {
         assert(sqlContext.getConf("spark.sql.with.or.without.you") == "my 
love")
       }
     
    -  test("Hadoop conf interaction between SQLContext and SparkContext") {
    -    val mySpecialKey = "mai.special.key"
    -    val mySpecialValue = "msv"
    -    try {
    -      sc.hadoopConfiguration.set(mySpecialKey, mySpecialValue)
    -      val sqlContext = SQLContext.getOrCreate(sc)
    -      val sessionState = sqlContext.sessionState
    -      assert(sessionState.hadoopConf.get(mySpecialKey) === mySpecialValue)
    -      assert(sqlContext.runtimeConf.getHadoop(mySpecialKey) === 
mySpecialValue)
    -      // mutating hadoop conf in SQL doesn't mutate the underlying one
    -      sessionState.hadoopConf.set(mySpecialKey, "no no no")
    -      assert(sessionState.hadoopConf.get(mySpecialKey) === "no no no")
    -      assert(sqlContext.runtimeConf.getHadoop(mySpecialKey) === "no no no")
    -      assert(sc.hadoopConfiguration.get(mySpecialKey) === mySpecialValue)
    -      sqlContext.runtimeConf.setHadoop(mySpecialKey, "yes yes yes")
    -      assert(sessionState.hadoopConf.get(mySpecialKey) === "yes yes yes")
    -      assert(sqlContext.runtimeConf.getHadoop(mySpecialKey) === "yes yes 
yes")
    --- End diff --
    
    there goes 10 minutes of my life...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to