Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r61215058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -894,11 +894,20 @@ object CombineFilters extends Rule[LogicalPlan] with
PredicateHelper {
/**
* Removes no-op SortOrder from Sort
*/
-object EliminateSorts extends Rule[LogicalPlan] {
+object EliminateSorts extends Rule[LogicalPlan] with PredicateHelper {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
case s @ Sort(orders, _, child) if orders.isEmpty ||
orders.exists(_.child.foldable) =>
val newOrders = orders.filterNot(_.child.foldable)
if (newOrders.isEmpty) child else s.copy(order = newOrders)
+ case s @ Sort(orders, _, p @ Project(projectList, grandChild)) =>
+ val aliasMap = AttributeMap(projectList.collect {
+ case a: Alias => (a.toAttribute, a.child)
+ })
+ val newOrders = orders
--- End diff --
i haven't actually look at the pr, but i think these few operations deserve
a lot more comment than they have right now (zero).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
