GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/12729
[SPARK-14951][SQL] Support subexpression elimination in TungstenAggregate
## What changes were proposed in this pull request?
We can support subexpression elimination in TungstenAggregate by using
current `EquivalentExpressions` which is already used in subexpression
elimination for expression codegen.
However, in wholestage codegen, we can't wrap the common expression's codes
in functions as before, we simply generate the code snippets for common
expressions. These code snippets are inserted before the common expressions are
actually used in generated java codes.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1
subexpr-elimination-tungstenaggregate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12729
----
commit 009d8668aabeadb4b3475ddf7bf4411f1b269786
Author: Liang-Chi Hsieh <[email protected]>
Date: 2016-04-27T08:34:48Z
Support subexpression elimination in TungstenAggregate.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
