Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12734#discussion_r61303166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
} else {
SaveMode.ErrorIfExists
}
- CreateTableUsingAsSelect(table, provider, temp, Array.empty, None,
mode, options, query)
+
+ val partitionColumnNames =
+ Option(ctx.partitionColumnNames)
+ .map(visitIdentifierList(_).toArray)
+ .getOrElse(Array.empty[String])
+
+ CreateTableUsingAsSelect(
+ table, provider, temp, partitionColumnNames, bucketSpec, mode,
options, query)
} else {
- val struct = Option(ctx.colTypeList).map(createStructType)
+ val struct = Option(ctx.colTypeList()).map(createStructType)
--- End diff --
One thing that is not very related to this pr. I always find that the
keyword `CLUSTERED BY` is very confusing, because there is a `CLUSTER BY`
keyword (, which is `DISTRIBUTE BY` + `SORT BY`). But, we do not need to change
it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
