GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/12739
[SPARK-14955] [SQL] avoid stride value equals to zero ## What changes were proposed in this pull request? In the columnPartition() method of JDBCRelation, stride is used for calculating the increment. But in some cases, this value could be zero, for example, lowerBound=0, upperBound=7, numOfPartition=8, which put all the data into one partition (last partition). This fix will try to make stride calculation more robust. I have also added require() to validate the input. equals() is added for overriding the parents equals() method, together with hashCode(). I have also fixed some text style, make keywords all uppercase. ## How was this patch tested? New test cases were added to JDBCSuite. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bomeng/spark SPARK-14955 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12739.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12739 ---- commit b4df4b0626a4bab197eb249fea99283ba4afd293 Author: bomeng <bm...@us.ibm.com> Date: 2016-04-27T18:31:28Z fix stride ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org