Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12736#discussion_r61320766
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java ---
@@ -291,7 +291,7 @@ public void testSetOperation() {
unioned.collectAsList());
Dataset<String> subtracted = ds.except(ds2);
- Assert.assertEquals(Arrays.asList("abc", "abc"),
subtracted.collectAsList());
+ Assert.assertEquals(Arrays.asList("abc"), subtracted.collectAsList());
--- End diff --
We have to decide what we should do next? This PR is doing `Except
Distinct`.
If we want to keep the existing behavior, which is `Except All`, we need to
change the external API in Dataset.
However, the current SQL interface for `Except` is wrong. We need to
correct it at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
