Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12596#discussion_r61337646
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -85,7 +85,8 @@ object LassoModel extends Loader[LassoModel] {
* See also the documentation for the precise formulation.
*/
@Since("0.8.0")
-@deprecated("Use ml.regression.LinearRegression with elasticNetParam =
1.0", "2.0.0")
+@deprecated("Use ml.regression.LinearRegression with elasticNetParam = 1.0
and regParam = 0.01",
--- End diff --
Now that I read this, I'm afraid it will confuse users, who might think
they *have* to use regParam = 0.01. Can you please change this to say "Use
ml.regression.LinearRegression with elasticNetParam = 1.0. Note the default
regParam is 0.01 for LassoWithSGD, but is 0.0 for LinearRegression."
Same elsewhere. Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
