Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215236672
Thanks @olarayej for updating this. I think the code looks good. The only
thing I'm not sure of is the default value for `[` - I see that you have gone
through SparkR's internal code base to add `drop = F`. The reason I prefer keep
`drop=F` as the default is that I'm not sure if we have missed some place where
we use `[`. While I see the argument that its the default in normal R, I feel
like it might not be worth changing the default if we'll run into other
unexpected bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
