GitHub user jodersky opened a pull request:

    https://github.com/apache/spark/pull/12745

    [SPARK-10001][Core][Hotfix] Don't short-circuit actions in signal handlers

    ## What changes were proposed in this pull request?
    The current signal handlers have a subtle bug that stops evaluating 
registered actions as soon as one of them returns true, this is because 
`forall` is short-circuited.
    This PR adds a strict mapping stage before evaluating returned result.
    There are no known occurrences of the bug and this is a preemptive fix.
    
    ## How was this patch tested?
    As with the original introduction of signal handlers, this was tested 
manually (unit testing with signals is not straightforward).
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jodersky/spark SPARK-10001-hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12745
    
----
commit 7fe0e54c5e39ff942fd58a16d5e5e309887ee883
Author: Jakob Odersky <[email protected]>
Date:   2016-04-27T22:26:41Z

    Evaluate all actions in signal handlers (don't short-circuit)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to