Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12259#discussion_r61351414
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLlibTestSparkContext.scala ---
@@ -24,14 +24,18 @@ import org.scalatest.Suite
import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.ml.util.TempDirectory
-import org.apache.spark.sql.SQLContext
+import org.apache.spark.sql.{SQLContext, SQLImplicits}
import org.apache.spark.util.Utils
trait MLlibTestSparkContext extends TempDirectory { self: Suite =>
@transient var sc: SparkContext = _
@transient var sqlContext: SQLContext = _
@transient var checkpointDir: String = _
+ protected object testImplicits extends SQLImplicits {
--- End diff --
This is useful to add. But if it is no longer required if we simplify the
unit tests above. We can make this change in a follow-up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
