Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12744#discussion_r61362822
--- Diff: core/src/test/scala/org/apache/spark/DistributedSuite.scala ---
@@ -51,18 +51,21 @@ class DistributedSuite extends SparkFunSuite with
Matchers with LocalSparkContex
}
test("local-cluster format") {
- sc = new SparkContext("local-cluster[2,1,1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[2 , 1 , 1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[2, 1, 1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[ 2, 1, 1024 ]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
+ import SparkMasterRegex._
+
+ val masterStrings = Seq(
+ "local-cluster[2,1,1024]",
+ "local-cluster[2 , 1 , 1024]",
+ "local-cluster[2, 1, 1024]",
+ "local-cluster[ 2, 1, 1024 ]"
+ )
+
+ masterStrings.map(x => x match {
--- End diff --
Actually, spotted another style problem: this should be `forEach` and not
`map` since it's being executed only for side-effects.
You can just write
```
masterStrings.forEach {
case ...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
