Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12612#discussion_r61371102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregateExec.scala
---
@@ -46,7 +46,7 @@ case class SortBasedAggregateExec(
AttributeSet(aggregateBufferAttributes)
override private[sql] lazy val metrics = Map(
- "numOutputRows" -> SQLMetrics.createLongMetric(sparkContext, "number
of output rows"))
+ "numOutputRows" -> SQLMetrics.createSumMetric(sparkContext, "number of
output rows"))
--- End diff --
hm I think createLongMetric makes more sense than createSumMetric here ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
