Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1361#discussion_r15724782
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -174,17 +182,18 @@ object GradientDescent extends Logging {
weights, Vectors.dense(new Array[Double](weights.size)), 0, 1,
regParam)._2
for (i <- 1 to numIterations) {
- val bcWeights = data.context.broadcast(weights)
--- End diff --
Broadcasting the weights is actually important for performance. Did you
experience any problem with it? It may be an orthogonal issue. Maybe we should
keep this code block unchanged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
