Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12723#issuecomment-215439643
I saw you put ```save/load``` tests at tests.py rather than in doctest. I
think the doctest is not only unit tests but also used for illustrating how to
use this ```Estimator/Model```. It's better to have simple test for
```save/load``` in doc test. LGTM otherwise. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
