Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12419#discussion_r61462095
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
---
@@ -379,15 +379,21 @@ class RowMatrix @Since("1.0.0") (
*
* Note that this cannot be computed on matrices with more than 65535
columns.
*
- * @param k number of top principal components.
+ * @param filter either the number of top principal components or
variance
+ * retained by the minimal set of principal components.
* @return a matrix of size n-by-k, whose columns are principal
components, and
* a vector of values which indicate how much variance each principal
component
* explains
*/
@Since("1.6.0")
- def computePrincipalComponentsAndExplainedVariance(k: Int): (Matrix,
Vector) = {
+ def computePrincipalComponentsAndExplainedVariance(filter: Either[Int,
Double])
--- End diff --
Aha you're right, it wasn't in 1.6. This is my fault:
https://github.com/apache/spark/commit/21b3d2a75f679b252e293000d706741dca33624a
It never was added to branch 1.6, despite the apparent intention. At this
point I think it should be considered 2.0+ and you can fix that annotation
here. So yeah this method was never 'released'. Still I think we want to do
something different with the argument anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
