Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12673#discussion_r61464196
  
    --- Diff: python/pyspark/sql/streaming.py ---
    @@ -51,22 +51,22 @@ def isActive(self):
             return self._jcq.isActive()
     
         @since(2.0)
    -    def awaitTermination(self, timeoutMs=None):
    +    def awaitTermination(self, timeout=None):
             """Waits for the termination of `this` query, either by 
:func:`query.stop()` or by an
             exception. If the query has terminated with an exception, then the 
exception will be thrown.
    -        If `timeoutMs` is set, it returns whether the query has terminated 
or not within the
    -        `timeoutMs` milliseconds.
    +        If `timeout` is set, it returns whether the query has terminated 
or not within the
    --- End diff --
    
    It might be good to mention what is returned if we time out (as we do in 
`awaitTerminationOrTimeout` on the `StreamingContext`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to